hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10365) BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
Date Wed, 12 Nov 2014 02:43:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207585#comment-14207585
] 

Akira AJISAKA commented on HADOOP-10365:
----------------------------------------

bq. So, need to cleanup.
Agree. The patch looks mostly good. Minor nits:
1.
{code}
+    } catch (IOException e) {
+      throw e;
{code}
These lines are no-op, so they can be removed.
2. 
{code}
+      outputStream = new BufferedOutputStream(new FileOutputStream(outputFile))
{code}
Would you please render the line within 80 characters?

> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-10365
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10365
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10365.2.patch, HADOOP-10365.patch
>
>
> {code}
>     BufferedOutputStream outputStream = new BufferedOutputStream(
>         new FileOutputStream(outputFile));
> ...
>     outputStream.flush();
>     outputStream.close();
> {code}
> outputStream should be closed in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message