Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0939617C7A for ; Thu, 9 Oct 2014 13:56:51 +0000 (UTC) Received: (qmail 29786 invoked by uid 500); 9 Oct 2014 13:56:45 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 29740 invoked by uid 500); 9 Oct 2014 13:56:45 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 29676 invoked by uid 99); 9 Oct 2014 13:56:44 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Oct 2014 13:56:44 +0000 Date: Thu, 9 Oct 2014 13:56:44 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11161) Expose close method in KeyProvider to give clients of Provider implementations a hook to release resources MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165149#comment-14165149 ] Hudson commented on HADOOP-11161: --------------------------------- FAILURE: Integrated in Hadoop-Hdfs-trunk #1896 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1896/]) HADOOP-11161. Expose close method in KeyProvider to give clients of Provider implementations a hook to release resources. Contribued by Arun Suresh. (atm: rev 2a51494ce1b05fc494fb3a818a7a3526f3f40070) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProviderCryptoExtension.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/ValueQueue.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProvider.java > Expose close method in KeyProvider to give clients of Provider implementations a hook to release resources > ---------------------------------------------------------------------------------------------------------- > > Key: HADOOP-11161 > URL: https://issues.apache.org/jira/browse/HADOOP-11161 > Project: Hadoop Common > Issue Type: Bug > Reporter: Arun Suresh > Assignee: Arun Suresh > Fix For: 2.6.0 > > Attachments: HADOOP-11161.1.patch, HADOOP-11161.2.patch, HADOOP-11161.3.patch > > > The {{KMSClientProvider}} class needs to be have a {{close()}} method to shutdown back ground executor threads. > The {{DFSClient}} creates an instance of a {{KeyProvider}} during initialization. If this KP is a {{KMSClientProvider}}, this needs to be closed to prevent thread leakage -- This message was sent by Atlassian JIRA (v6.3.4#6332)