Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2901417393 for ; Mon, 27 Oct 2014 21:10:35 +0000 (UTC) Received: (qmail 19376 invoked by uid 500); 27 Oct 2014 21:10:34 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 19295 invoked by uid 500); 27 Oct 2014 21:10:34 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 19074 invoked by uid 99); 27 Oct 2014 21:10:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Oct 2014 21:10:34 +0000 Date: Mon, 27 Oct 2014 21:10:34 +0000 (UTC) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10926) Improve test-patch.sh to apply binary diffs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185817#comment-14185817 ] Hadoop QA commented on HADOOP-10926: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12677399/HADOOP-10926.001.patch against trunk revision 5b1dfe7. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4962//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4962//console This message is automatically generated. > Improve test-patch.sh to apply binary diffs > ------------------------------------------- > > Key: HADOOP-10926 > URL: https://issues.apache.org/jira/browse/HADOOP-10926 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 3.0.0 > Reporter: Andrew Wang > Assignee: Colin Patrick McCabe > Attachments: HADOOP-10926.001.patch > > > The Unix {{patch}} command cannot apply binary diffs as generated via {{git diff --binary}}. This means we cannot get effective test-patch.sh runs when the patch requires adding a binary file. > We should consider using a different patch method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)