hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11182) GraphiteSink emits wrong timestamps
Date Fri, 10 Oct 2014 22:52:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167720#comment-14167720
] 

Hadoop QA commented on HADOOP-11182:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12674159/HADOOP-11182-GraphiteSink-v1.patch
  against trunk revision d3d3d47.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new Findbugs (version
2.0.3) warnings.

        {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4902//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4902//artifact/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4902//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4902//console

This message is automatically generated.

> GraphiteSink emits wrong timestamps
> -----------------------------------
>
>                 Key: HADOOP-11182
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11182
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.5.0, 2.5.1
>            Reporter: Sascha Coenen
>         Attachments: HADOOP-11182-GraphiteSink-v1.patch
>
>
> the org.apache.hadoop.metrics2.sink.GraphiteSink class emits metrics at the configured
time period, but the timestamps written only change every 128 seconds, even it the configured
time period in the configuration file is much shorter.
> This is due to a bug in line 93:
> {code:java}
> 092            // Round the timestamp to second as Graphite accepts it in such format.
> 093            int timestamp = Math.round(record.timestamp() / 1000.0f);
> {code}
> The timestamp property is a long and is divided by a float which yields a result that
is not precise enough and yields same valued results for timestamps that lie up to 128 seconds
apart. Also, the result is then written into an int variable.
> One solution would be to divide by 1000.0d, but the best fix would be to not even convert
to a decimal format in the first place. Instead one could replace the line with the following:
> {code:java}
>    long timestamp = record.timestamp() / 1000L;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message