hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10926) Improve test-patch.sh to apply binary diffs
Date Mon, 27 Oct 2014 23:05:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185984#comment-14185984
] 

Andrew Wang commented on HADOOP-10926:
--------------------------------------

+1 LGTM, thanks Colin. As Colin told me offline, he tested manually with a few different patch
scenarios.

> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
>                 Key: HADOOP-10926
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10926
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Colin Patrick McCabe
>         Attachments: HADOOP-10926.001.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git diff --binary}}.
This means we cannot get effective test-patch.sh runs when the patch requires adding a binary
file.
> We should consider using a different patch method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message