hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10365) BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
Date Fri, 24 Oct 2014 12:23:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182728#comment-14182728
] 

Tsuyoshi OZAWA commented on HADOOP-10365:
-----------------------------------------

[~yunsh], thanks for updating a patch. I rethought of the usage of IOUtils - in fact, unpackEntries
is only called from FileUtil#unTarUsingJava. FileUtil#unTarUsingJava closes all inputStream
in finally block if there are any exceptions in unpackEntries. So, I think we don't need to
cleanup the descriptors in unpackEntries. What do you think?

> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-10365
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10365
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10365.2.patch, HADOOP-10365.patch
>
>
> {code}
>     BufferedOutputStream outputStream = new BufferedOutputStream(
>         new FileOutputStream(outputFile));
> ...
>     outputStream.flush();
>     outputStream.close();
> {code}
> outputStream should be closed in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message