Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 25 Sep 2014 01:40:34 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12742103.1410950933000.117853.1411609234030@Atlassian.JIRA>
In-Reply-To: <JIRA.12742103.1410950933000@Atlassian.JIRA>
References: <JIRA.12742103.1410950933000@Atlassian.JIRA>
 <JIRA.12742103.1410950933684@arcas>
Subject: [jira] [Commented] (HADOOP-11101) How about inputstream close
 statement from catch block to finally block in FileContext#copy() ?
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147235#comment-14147235 ] 

Hadoop QA commented on HADOOP-11101:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12671103/HADOOP-11101_002.patch
  against trunk revision c86674a.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4805//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4805//artifact/PreCommit-HADOOP-Build-patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4805//console

This message is automatically generated.

> How about inputstream close statement from catch block to finally block in FileContext#copy() ?
> -----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11101
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11101
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.5.1
>            Reporter: skrho
>            Priority: Minor
>         Attachments: HADOOP-11101_001.patch, HADOOP-11101_002.patch
>
>
> If IOException is happended, can be catched exception block.. 
> But another excpetion is happended, can't be catched exception block.. also Stream object can't be closed..
>         try {
>           in = open(qSrc);
>           EnumSet<CreateFlag> createFlag = overwrite ? EnumSet.of(
>               CreateFlag.CREATE, CreateFlag.OVERWRITE) : 
>                 EnumSet.of(CreateFlag.CREATE);
>           out = create(qDst, createFlag);
>           IOUtils.copyBytes(in, out, conf, true);
>         } catch (IOException e) {
>           IOUtils.closeStream(out);
>           IOUtils.closeStream(in);
>           throw e;
>         }


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)