Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CEEBD11B50 for ; Fri, 12 Sep 2014 21:50:35 +0000 (UTC) Received: (qmail 51460 invoked by uid 500); 12 Sep 2014 21:50:35 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 51415 invoked by uid 500); 12 Sep 2014 21:50:35 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 51393 invoked by uid 99); 12 Sep 2014 21:50:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Sep 2014 21:50:35 +0000 Date: Fri, 12 Sep 2014 21:50:34 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-11088) Unittest TestKeyShell, TestCredShell and TestKMS assume UNIX path separator for JECKS key store path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-11088: ----------------------------------- Hadoop Flags: Reviewed +1 for the patch. I verified that it works on Mac and Windows. I'll commit this. > Unittest TestKeyShell, TestCredShell and TestKMS assume UNIX path separator for JECKS key store path > ---------------------------------------------------------------------------------------------------- > > Key: HADOOP-11088 > URL: https://issues.apache.org/jira/browse/HADOOP-11088 > Project: Hadoop Common > Issue Type: Test > Components: security > Affects Versions: 2.4.1 > Reporter: Xiaoyu Yao > Assignee: Xiaoyu Yao > Fix For: 2.5.1 > > Attachments: HADOOP-11088.0.patch, HADOOP-11088.1.patch > > > TestKeyShell and TestCredShell assume UNIX path separator for JECKS key store path. This will fail the tests on Windows which uses a different path separator. The fix should be something like: > {code} > - jceksProvider = "jceks://file" + tmpDir + "/keystore.jceks"; > + final Path jksPath = new Path(tmpDir.toString(), "keystore.jceks"); > + jceksProvider = "jceks://file" + jksPath.toUri(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)