hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-11105) MetricsSystemImpl could leak memory in registered callbacks
Date Thu, 18 Sep 2014 22:43:34 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HADOOP-11105:
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 2.6.0
           Status: Resolved  (was: Patch Available)

I committed this to trunk and branch-2.  Chuan, thank you for contributing the patch.  Haohui,
thank you for helping with code review.

> MetricsSystemImpl could leak memory in registered callbacks
> -----------------------------------------------------------
>
>                 Key: HADOOP-11105
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11105
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.5.1
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>             Fix For: 2.6.0
>
>         Attachments: HADOOP-11105.2.patch, HADOOP-11105.patch, memory_leak_1.png, memory_leak_2.png
>
>
> In {{MetricsSystemImpl.register(final String name, final String description, final T
sink)}} method, we will also add a callback function to the {{callbacks}} array list. However,
upon unregistering, the callback function is not removed from the list in existing code. As
a result, the memory allocated for the callback function could accumulate in the {{MetricsSystemImpl}}
list. In one of our cluster, we have seen a case where there are about 874 MB memory retained
by {{MetricsSystemImpl}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message