hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11105) MetricsSystemImpl could leak memory in registered callbacks
Date Thu, 18 Sep 2014 20:29:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139445#comment-14139445
] 

Hadoop QA commented on HADOOP-11105:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12669778/HADOOP-11105.2.patch
  against trunk revision 570b8b4.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4760//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4760//console

This message is automatically generated.

> MetricsSystemImpl could leak memory in registered callbacks
> -----------------------------------------------------------
>
>                 Key: HADOOP-11105
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11105
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>         Attachments: HADOOP-11105.2.patch, HADOOP-11105.patch, memory_leak_1.png, memory_leak_2.png
>
>
> In {{MetricsSystemImpl.register(final String name, final String description, final T
sink)}} method, we will also add a callback function to the {{callbacks}} array list. However,
upon unregistering, the callback function is not removed from the list in existing code. As
a result, the memory allocated for the callback function could accumulate in the {{MetricsSystemImpl}}
list. In one of our cluster, we have seen a case where there are about 874 MB memory retained
by {{MetricsSystemImpl}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message