hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11101) How about inputstream close statement from catch block to finally block in FileContext#copy() ?
Date Wed, 17 Sep 2014 11:49:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137107#comment-14137107
] 

Hadoop QA commented on HADOOP-11101:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12669383/HADOOP-11101_001.patch
  against trunk revision c0c7e6f.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4746//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4746//console

This message is automatically generated.

> How about inputstream close statement from catch block to finally block in FileContext#copy()
?
> -----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11101
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11101
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.5.1
>            Reporter: skrho
>            Priority: Minor
>         Attachments: HADOOP-11101_001.patch
>
>
> If IOException is happended, can be catched exception block.. 
> But another excpetion is happended, can't be catched exception block.. also Stream object
can't be closed..
>         try {
>           in = open(qSrc);
>           EnumSet<CreateFlag> createFlag = overwrite ? EnumSet.of(
>               CreateFlag.CREATE, CreateFlag.OVERWRITE) : 
>                 EnumSet.of(CreateFlag.CREATE);
>           out = create(qDst, createFlag);
>           IOUtils.copyBytes(in, out, conf, true);
>         } catch (IOException e) {
>           IOUtils.closeStream(out);
>           IOUtils.closeStream(in);
>           throw e;
>         }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message