hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11088) Unittest TestKeyShell, TestCredShell and TestKMS assume UNIX path separator for JECKS key store path
Date Fri, 12 Sep 2014 21:02:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132104#comment-14132104
] 

Chris Nauroth commented on HADOOP-11088:
----------------------------------------

Hi, [~xyao].  In {{KMSConfiguration}}, I think we'll want to preserve the validation checks
that the configuration directory is an absolute path.  The existing implementation that checks
for '/' as the first character is incorrect though.  Instead, we can check {{Path#isUriPathAbsolute}}.
 That method is already implemented to handle this correctly cross-platform.

Otherwise, the patch looks good.

> Unittest TestKeyShell, TestCredShell and TestKMS assume UNIX path separator for JECKS
key store path
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11088
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11088
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: security
>    Affects Versions: 2.4.1
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>             Fix For: 2.5.1
>
>         Attachments: HADOOP-11088.0.patch
>
>
> TestKeyShell and TestCredShell assume UNIX path separator for JECKS key store path. This
will fail the tests on Windows which uses a different path separator. The fix should be something
like:
> {code}
> -    jceksProvider = "jceks://file" + tmpDir + "/keystore.jceks";
> +    final Path jksPath = new Path(tmpDir.toString(), "keystore.jceks");
> +    jceksProvider = "jceks://file" + jksPath.toUri();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message