hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11073) Credential Provider related Unit Tests Failure on Windows
Date Mon, 08 Sep 2014 04:36:29 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125208#comment-14125208
] 

Chris Nauroth commented on HADOOP-11073:
----------------------------------------

[~xyao], is there any chance that you're running JDK 8 on your Windows VM?  I noticed this
bug report on OpenJDK 8:

https://bugs.openjdk.java.net/browse/JDK-8040820

I'm running OpenJDK 1.7.0_55, and the test passes for me.  Version 8 isn't officially supported
yet, so as long as it passes with version 7, I think we're OK to commit this patch.  Please
let me know.  Thanks!

> Credential Provider related Unit Tests Failure on Windows
> ---------------------------------------------------------
>
>                 Key: HADOOP-11073
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11073
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: security
>    Affects Versions: 2.4.1
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HADOOP-11073.0.patch, HADOOP-11073.1.patch
>
>
> Reported by: Xiaomara and investigated by [~cnauroth].
> The credential provider related unit tests failed on Windows. The tests try to set up
a URI by taking the build test directory and concatenating it with other strings containing
the rest of the URI format, i.e.:
> {code}
>   public void testFactory() throws Exception {
>     Configuration conf = new Configuration();
>     conf.set(CredentialProviderFactory.CREDENTIAL_PROVIDER_PATH,
>         UserProvider.SCHEME_NAME + ":///," +
>             JavaKeyStoreProvider.SCHEME_NAME + "://file" + tmpDir + "/test.jks");
> {code}
> This logic is incorrect on Windows, because the file path separator will be '\', which
violates URI syntax. Forward slash is not permitted. 
> The proper fix is to always do path/URI construction through the org.apache.hadoop.fs.Path
class, specifically using the constructors that take explicit parent and child arguments.
> The affected unit tests are:
> {code}
> * TestKeyProviderFactory
> * TestLdapGroupsMapping
> * TestCredentialProviderFactory
> * KeyStoreTestUtil
> * TestSSLFactory
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message