hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Steelman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11044) FileSystem counters can overflow for large number of readOps, largeReadOps, writeOps
Date Wed, 03 Sep 2014 21:42:52 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120515#comment-14120515
] 

Gary Steelman commented on HADOOP-11044:
----------------------------------------

I've noticed the javac logs haven't been available on other patches lately either, [~sdaingade].


For unit tests, let us keep the methods testing the int versions, but also add ones that test
the long versions. This way we get higher test coverage and when we remove the int methods
later, we can remove the associated tests with no other changes.

> FileSystem counters can overflow for large number of readOps, largeReadOps, writeOps
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11044
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11044
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.5.0, 2.4.1
>            Reporter: Swapnil Daingade
>            Priority: Minor
>         Attachments: 11044.patch2
>
>
> The org.apache.hadoop.fs.FileSystem.Statistics.StatisticsData class defines readOps,
largeReadOps, writeOps as int. Also the The org.apache.hadoop.fs.FileSystem.Statistics class
has methods like getReadOps(), getLargeReadOps() and getWriteOps() that return int. These
int values can overflow if the exceed 2^31-1 showing negative values. It would be nice if
these can be changed to long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message