Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 28 Aug 2014 03:31:58 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12737275.1409187232800.29698.1409196718230@arcas>
In-Reply-To: <JIRA.12737275.1409187232800@arcas>
References: <JIRA.12737275.1409187232800@arcas>
Subject: [jira] [Commented] (HADOOP-11014) Potential resource leak in
 JavaKeyStoreProvider due to unclosed stream
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113288#comment-14113288 ] 

Hadoop QA commented on HADOOP-11014:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12664806/HADOOP-11014.3.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4563//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4563//console

This message is automatically generated.

> Potential resource leak in JavaKeyStoreProvider due to unclosed stream
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-11014
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11014
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: HADOOP-11014.1.patch, HADOOP-11014.2.patch, HADOOP-11014.3.patch
>
>
> From hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java :
> {code}
>   private void writeToNew(Path newPath) throws IOException {
>     FSDataOutputStream out =
>         FileSystem.create(fs, newPath, permissions);
>     try {
>       keyStore.store(out, password);
>     } catch (KeyStoreException e) {
>       throw new IOException("Can't store keystore " + this, e);
>     } catch (NoSuchAlgorithmException e) {
>       throw new IOException(
>           "No such algorithm storing keystore " + this, e);
>     } catch (CertificateException e) {
>       throw new IOException(
>           "Certificate exception storing keystore " + this, e);
>     }
>     out.close();
> {code}
> IOException is not among the catch blocks.
> According to http://docs.oracle.com/javase/7/docs/api/java/security/KeyStore.html#store(java.io.OutputStream,%20char[]), IOException may be thrown from the store() call. In that case, out would be left unclosed.
> In loadFromPath():
> {code}
>     keyStore.load(fs.open(p), password);
> {code}
> The InputStream should be closed upon return from load()


--
This message was sent by Atlassian JIRA
(v6.2#6252)