Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 13 Aug 2014 15:38:21 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12733697.1407913111080.72554.1407944301251@arcas>
In-Reply-To: <JIRA.12733697.1407913111080@arcas>
References: <JIRA.12733697.1407913111080@arcas>
Subject: [jira] [Commented] (HADOOP-10964) Small fix for
 NetworkTopologyWithNodeGroup#sortByDistance
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095604#comment-14095604 ] 

Hadoop QA commented on HADOOP-10964:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12661443/HADOOP-10964.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverControllerStress

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4462//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4462//console

This message is automatically generated.

> Small fix for NetworkTopologyWithNodeGroup#sortByDistance
> ---------------------------------------------------------
>
>                 Key: HADOOP-10964
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10964
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>            Priority: Minor
>         Attachments: HADOOP-10964.001.patch
>
>
> {{nodes.length}} should be {{activeLen}}.
> {code}
>   @Override
>   public void sortByDistance(Node reader, Node[] nodes, int activeLen,
>       long seed, boolean randomizeBlockLocationsPerBlock) {
>     // If reader is not a datanode (not in NetworkTopology tree), we need to
>     // replace this reader with a sibling leaf node in tree.
>     if (reader != null && !this.contains(reader)) {
>       Node nodeGroup = getNode(reader.getNetworkLocation());
>       if (nodeGroup != null && nodeGroup instanceof InnerNode) {
>         InnerNode parentNode = (InnerNode) nodeGroup;
>         // replace reader with the first children of its parent in tree
>         reader = parentNode.getLeaf(0, null);
>       } else {
>         return;
>       }
>     }
>     super.sortByDistance(reader, nodes, nodes.length, seed,
>         randomizeBlockLocationsPerBlock);
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.2#6252)