Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB68911E35 for ; Tue, 5 Aug 2014 02:16:12 +0000 (UTC) Received: (qmail 2181 invoked by uid 500); 5 Aug 2014 02:16:12 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 2111 invoked by uid 500); 5 Aug 2014 02:16:12 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 2089 invoked by uid 99); 5 Aug 2014 02:16:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2014 02:16:12 +0000 Date: Tue, 5 Aug 2014 02:16:12 +0000 (UTC) From: "Larry McCay (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10224) JavaKeyStoreProvider has to protect against corrupting underlying store MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085673#comment-14085673 ] Larry McCay commented on HADOOP-10224: -------------------------------------- Thanks for the patch for this - it will be helpful in both the KeyProvider and CredentialProvider APIs! Personally, I think that we can make that method a bit more concise and readable - consolidate the boilerplate code that verifies that the old or new keystores can be loaded, renamed and/or deleted into a common method. Also, break the other exception handling blocks into separate methods. This is just for readability and maintainability. I will try and dig into the actual behavior there tomorrow. Hopefully, with a more easily read version? :) > JavaKeyStoreProvider has to protect against corrupting underlying store > ----------------------------------------------------------------------- > > Key: HADOOP-10224 > URL: https://issues.apache.org/jira/browse/HADOOP-10224 > Project: Hadoop Common > Issue Type: Bug > Components: security > Reporter: Larry McCay > Assignee: Arun Suresh > Attachments: HADOOP-10224.1.patch, HADOOP-10224.2.patch, HADOOP-10224.3.patch, HADOOP-10224.4.patch, HADOOP-10224.5.patch, HADOOP-10224.6.patch, HADOOP-10224.7.patch > > > Java keystores get corrupted at times. A key management operation that writes the store to disk could cause a corruption and all protected data would then be unaccessible. -- This message was sent by Atlassian JIRA (v6.2#6252)