hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11000) HAServiceProtocol's health state is incorrectly transitioned to SERVICE_NOT_RESPONDING
Date Tue, 26 Aug 2014 11:39:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110622#comment-14110622
] 

Vinayakumar B commented on HADOOP-11000:
----------------------------------------

+1, Looks good to me as well.
Good finding [~mingma]. 
Though there is no much functional difference, correct state changes make sense.

> HAServiceProtocol's health state is incorrectly transitioned to SERVICE_NOT_RESPONDING
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11000
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11000
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HADOOP-11000-2.patch, HADOOP-11000.patch
>
>
> When HAServiceProtocol.monitorHealth throws a HealthCheckFailedException, the actual
exception from protocol buffer RPC is a RemoteException that wraps the real exception. Thus
the state is incorrectly transitioned to SERVICE_NOT_RESPONDING
> {noformat}
> HealthMonitor.java
> doHealthChecks
>       try {
>         status = proxy.getServiceStatus();
>         proxy.monitorHealth();
>         healthy = true;
>       } catch (HealthCheckFailedException e) {
>         .....
>         enterState(State.SERVICE_UNHEALTHY);
>       } catch (Throwable t) {
>         .....
>         enterState(State.SERVICE_NOT_RESPONDING);
>         .....
>       }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message