hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10940) RPC client does no bounds checking of responses
Date Thu, 14 Aug 2014 17:18:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097234#comment-14097234

Daryn Sharp commented on HADOOP-10940:

bq. Is this comment still valid? It looks like even non-SASL clients are now using IpcStreams.

A bit confused.  What else is using it besides the ipc Client itself?

I'll update the comment about why it shouldn't flush, but not sure if mentioning context switches
is germane.

bq.  Do we need this comment here? There wasn't a flush here earlier.

It used to implicitly flush because the stream wasn't buffered (yet).

bq. why not just have the callers who want to flush call ioStreams.out.flush() ... it means
that we need a comment to explain the value of the boolean everywhere.

I had two considerations:
# I wanted to avoid exposing {{out}} as public just for {{SaslRpcClient}}
# The comments aren't intended to document the boolean but to convey the deliberate intent
to (not) flush.  Otherwise, someone may come along in the future and think "this is odd, a
write with no flush?  let's add a flush!" and accidentally re-introduce the bug.

> RPC client does no bounds checking of responses
> -----------------------------------------------
>                 Key: HADOOP-10940
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10940
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Critical
>         Attachments: HADOOP-10940.patch, HADOOP-10940.patch
> The rpc client does no bounds checking of server responses.  In the case of communicating
with an older and incompatible RPC, this may lead to OOM issues and leaking of resources.

This message was sent by Atlassian JIRA

View raw message