hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10926) Improve test-patch.sh to apply binary diffs
Date Fri, 01 Aug 2014 23:03:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083139#comment-14083139
] 

Andrew Wang commented on HADOOP-10926:
--------------------------------------

Switching to use {{git apply --binary}} instead makes the most sense to me, since I know that
almost all of us use git anyway. I looked into this a bit, and we'd need the following:

* smart-apply-patch.sh assumes {{patch}}-specific options, e.g. {{-E --dry-run}}
* Jenkins PreCommit job is passing in /usr/bin/patch, would need to update this to point to
"git apply" instead
* Need to make sure that git is installed on the build boxes. Needs to be a recent version
too, I know older versions had some issues.

I've asked about shell access to the build boxes to check their git versions. Shell access
will also be useful for manual testing, since making the flip to git apply also requires updating
the Jenkins job.

> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
>                 Key: HADOOP-10926
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10926
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git diff --binary}}.
This means we cannot get effective test-patch.sh runs when the patch requires adding a binary
file.
> We should consider using a different patch method.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message