hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larry McCay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10224) JavaKeyStoreProvider has to protect against corrupting underlying store
Date Tue, 05 Aug 2014 02:16:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085673#comment-14085673
] 

Larry McCay commented on HADOOP-10224:
--------------------------------------

Thanks for the patch for this - it will be helpful in both the KeyProvider and CredentialProvider
APIs!

Personally, I think that we can make that method a bit more concise and readable - consolidate
the boilerplate code that verifies that the old or new keystores can be loaded, renamed and/or
deleted into a common method. Also, break the other exception handling blocks into separate
methods. This is just for readability and maintainability. 

I will try and dig into the actual behavior there tomorrow. Hopefully, with a more easily
read version? :)


> JavaKeyStoreProvider has to protect against corrupting underlying store
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-10224
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10224
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: Larry McCay
>            Assignee: Arun Suresh
>         Attachments: HADOOP-10224.1.patch, HADOOP-10224.2.patch, HADOOP-10224.3.patch,
HADOOP-10224.4.patch, HADOOP-10224.5.patch, HADOOP-10224.6.patch, HADOOP-10224.7.patch
>
>
> Java keystores get corrupted at times. A key management operation that writes the store
to disk could cause a corruption and all protected data would then be unaccessible.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message