hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9646) Inconsistent exception specifications in FileUtils#chmod
Date Fri, 15 Aug 2014 09:14:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098372#comment-14098372
] 

Hadoop QA commented on HADOOP-9646:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12587901/HADOOP-9646.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 javac{color:red}.  The patch appears to cause the build to fail.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4479//console

This message is automatically generated.

> Inconsistent exception specifications in FileUtils#chmod
> --------------------------------------------------------
>
>                 Key: HADOOP-9646
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9646
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.6.0
>
>         Attachments: HADOOP-9646.001.patch, HADOOP-9646.002.patch
>
>
> There are two FileUtils#chmod methods:
> {code}
> public static int chmod(String filename, String perm
>                           ) throws IOException, InterruptedException;
> public static int chmod(String filename, String perm, boolean recursive)
>                             throws IOException;
> {code}
> The first one just calls the second one with {{recursive = false}}, but despite that
it is declared as throwing {{InterruptedException}}, something the second one doesn't declare.
> The new Java7 chmod API, which we will transition to once JDK6 support is dropped, does
*not* throw {{InterruptedException}}
> See [http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#setOwner(java.nio.file.Path,
java.nio.file.attribute.UserPrincipal)]
> So we should make these consistent by removing the {{InterruptedException}}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message