Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 15 Jul 2014 12:09:05 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12727308.1405419616556.44250.1405426145039@arcas>
In-Reply-To: <JIRA.12727308.1405419616556@arcas>
References: <JIRA.12727308.1405419616556@arcas>
Subject: [jira] [Commented] (HADOOP-10825) Refactor class creation logic in
 Configuration into nested class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HADOOP-10825?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14=
061990#comment-14061990 ]=20

Hadoop QA commented on HADOOP-10825:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest a=
ttachment=20
  http://issues.apache.org/jira/secure/attachment/12655741/HADOOP-10811-108=
25.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author=
 tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to inclu=
de any new or modified tests.
                        Please justify why no new tests are needed for this=
 patch.
                        Also please list what manual steps were performed t=
o verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the =
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning mess=
ages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:e=
clipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new =
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not incre=
ase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in =
hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
                  org.apache.hadoop.ipc.TestIPC
                  org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit te=
sts.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4272//te=
stReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4272//=
console

This message is automatically generated.

> Refactor class creation logic in Configuration into nested class
> ----------------------------------------------------------------
>
>                 Key: HADOOP-10825
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10825
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: conf
>            Reporter: Chris Li
>            Assignee: Chris Li
>            Priority: Minor
>         Attachments: HADOOP-10811-10825.patch
>
>
> This first patch refactors class creation inside Configuration into a nes=
ted class called ClassCreator (a pretty uninspired name; I=E2=80=99m up for=
 better naming suggestions).=20
> Since this is a refactor that adds no new features, I have not included a=
 test.


--
This message was sent by Atlassian JIRA
(v6.2#6252)