Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 82DC111E89 for ; Wed, 9 Jul 2014 04:19:05 +0000 (UTC) Received: (qmail 6515 invoked by uid 500); 9 Jul 2014 04:19:05 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 6462 invoked by uid 500); 9 Jul 2014 04:19:04 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 6448 invoked by uid 99); 9 Jul 2014 04:19:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 04:19:04 +0000 Date: Wed, 9 Jul 2014 04:19:04 +0000 (UTC) From: "Dmitry Sivachenko (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10797) Hardcoded path to "bash" is not portable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055832#comment-14055832 ] Dmitry Sivachenko commented on HADOOP-10797: -------------------------------------------- Okay, I see. The point to use /bin/sh is that most of these shell scripts are very simple and do not require any bash-specific things. And since there are systems that do not ship bash by default, this would eliminate one extra dependency. But it is not a big deal if you prefer to stick with more heavyweight bash instead. > Hardcoded path to "bash" is not portable > ---------------------------------------- > > Key: HADOOP-10797 > URL: https://issues.apache.org/jira/browse/HADOOP-10797 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.4.1 > Reporter: Dmitry Sivachenko > Attachments: bash.patch > > > Most of shell scripts use shebang ling in the following format: > #!/usr/bin/env bash > But some scripts contain hardcoded "/bin/bash" which is not portable. > Please use #!/usr/bin/env bash instead for portability. > PS: it would be much better to switch to standard Bourne Shell /bin/sh, do these scripts really need bash? -- This message was sent by Atlassian JIRA (v6.2#6252)