Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 24 Jul 2014 03:36:38 +0000 (UTC)
From: "Stephen Chu (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12694307.1392054813263.34950.1406172998843@arcas>
In-Reply-To: <JIRA.12694307.1392054813263@arcas>
References: <JIRA.12694307.1392054813263@arcas>
Subject: [jira] [Commented] (HADOOP-10334) make user home directory
 customizable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072752#comment-14072752 ] 

Stephen Chu commented on HADOOP-10334:
--------------------------------------

Hi, [~yzhangal], nice changes! Couple comments/questions.

Why not camel case {{home_dir_base}}? I haven't seen that convention too much in the Hadoop codebase, but perhaps it's something I'm just not familiar with.

There's a {{Path(String parent, String child)}} constructor which might make it easier if you don't want to deal with {{+ "/" +}} between parent and child, but not a big deal.

I went through the 3 failing tests, and am pretty confident they're not related to this change.

> make user home directory customizable
> -------------------------------------
>
>                 Key: HADOOP-10334
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10334
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.2.0
>            Reporter: Kevin Odell
>            Assignee: Yongjun Zhang
>            Priority: Minor
>         Attachments: HADOOP-10334.001.patch
>
>
> The path is currently hardcoded:
> public Path getHomeDirectory() {
>     return makeQualified(new Path("/user/" + dfs.ugi.getShortUserName()));
>   }
> It would be nice to have that as a customizable value.  
> Thank you


--
This message was sent by Atlassian JIRA
(v6.2#6252)