hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10858) Specify the charset explicitly rather than rely on the default
Date Fri, 18 Jul 2014 10:13:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066225#comment-14066225
] 

Hadoop QA commented on HADOOP-10858:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12656477/HADOOP-10858.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.shell.TestCopyPreserveFlag
                  org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
                  org.apache.hadoop.fs.shell.TestTextCommand
                  org.apache.hadoop.ipc.TestIPC
                  org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
                  org.apache.hadoop.fs.shell.TestPathData
                  org.apache.hadoop.fs.TestDFVariations

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4313//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4313//console

This message is automatically generated.

> Specify the charset explicitly rather than rely on the default
> --------------------------------------------------------------
>
>                 Key: HADOOP-10858
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10858
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 3.0.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>         Attachments: HADOOP-10858.txt
>
>
> Findbugs 2 warns about relying on the default Java charset instead of specifying it explicitly.
Given that we're porting Hadoop to different platforms it's better to be explicit



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message