hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10826) Iteration on KeyProviderFactory.serviceLoader is thread-unsafe
Date Tue, 15 Jul 2014 12:09:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061989#comment-14061989
] 

Uma Maheswara Rao G commented on HADOOP-10826:
----------------------------------------------

I am not seeing this is called with multiple threads. no?
I see this is called only in FSNamesystem ctor. 

> Iteration on KeyProviderFactory.serviceLoader  is thread-unsafe
> ---------------------------------------------------------------
>
>                 Key: HADOOP-10826
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10826
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: HADOOP-10826.patch
>
>
> KeyProviderFactory uses _ServiceLoader_ framework to load _KeyProviderFactory_
> {code}
>   private static final ServiceLoader<KeyProviderFactory> serviceLoader =
>       ServiceLoader.load(KeyProviderFactory.class);
> {code}
> The _ServiceLoader_ framework does lazy initialization of services which makes it thread
unsafe. If accessed from multiple threads, it is better to synchronize the access.
> Similar synchronization has been done while loading compression codec providers via HADOOP-8406.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message