hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10826) Iteration on KeyProviderFactory.serviceLoader is thread-unsafe
Date Tue, 22 Jul 2014 13:27:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070243#comment-14070243

Hadoop QA commented on HADOOP-10826:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:


    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4338//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4338//console

This message is automatically generated.

> Iteration on KeyProviderFactory.serviceLoader  is thread-unsafe
> ---------------------------------------------------------------
>                 Key: HADOOP-10826
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10826
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: HADOOP-10826.patch, HADOOP-10826.patch, HADOOP-10826.patch, HADOOP-10826.patch
> KeyProviderFactory uses _ServiceLoader_ framework to load _KeyProviderFactory_
> {code}
>   private static final ServiceLoader<KeyProviderFactory> serviceLoader =
>       ServiceLoader.load(KeyProviderFactory.class);
> {code}
> The _ServiceLoader_ framework does lazy initialization of services which makes it thread
unsafe. If accessed from multiple threads, it is better to synchronize the access.
> Similar synchronization has been done while loading compression codec providers via HADOOP-8406.

This message was sent by Atlassian JIRA

View raw message