hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10818) native client: refactor URI code to be clearer
Date Sat, 12 Jul 2014 00:52:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059551#comment-14059551
] 

Colin Patrick McCabe commented on HADOOP-10818:
-----------------------------------------------

This refactor makes things easier to use because there's just one function to create hadoop
uris and another one to free them, rather than many as now.  It also fixes a use-after-free
issue that resulted from the UriUriA structure hanging on to pointers we had already freed.
 Finally I added {{dynprintf}}, which is a pretty thin wrapper around {{asprintf}}.

> native client: refactor URI code to be clearer
> ----------------------------------------------
>
>                 Key: HADOOP-10818
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10818
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: native
>    Affects Versions: HADOOP-10388
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HADOOP-10818-pnative.001.patch
>
>
> Refactor the {{common/uri.c}} code to be a bit clearer.  We should just be able to refer
to user_info, auth, port, path, etc. fields in the structure, rather than calling accessors.
 {{hdfsBuilder}} should just have a connection URI rather than separate fields for all these
things.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message