hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10816) key shell returns -1 to the shell on error, should be 1
Date Tue, 15 Jul 2014 00:09:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061459#comment-14061459
] 

Andrew Wang commented on HADOOP-10816:
--------------------------------------

Looks good overall. Do we want the tests to instead be doing assertEquals(1) rather than assertNotEquals(0)?
If someone changed a "return 1" to a "return 2" that would technically be an incompatible
change, so it'd be good to have this contract tested.

> key shell returns -1 to the shell on error, should be 1
> -------------------------------------------------------
>
>                 Key: HADOOP-10816
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10816
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Mike Yoder
>            Assignee: Mike Yoder
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-10816.001.patch
>
>
> I've seen this in several places now - commands returning -1 on failure to the shell.
It's a bug. Someone confused their posix style returns (0 on success, < 0 on failure) with
program returns, which are an unsigned character. Thus, a return of -1 actually becomes 255
to the shell.
> {noformat}
> $ hadoop key create happykey2 --provider kms://http@localhost:16000/kms --attr "a=a"
--attr "a=b"
> Each attribute must correspond to only one value:
> atttribute "a" was repeated
> ...
> $ echo $?
> 255
> {noformat}
> A return value of 1 instead of -1 does the right thing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message