hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10781) Unportable getgrouplist() usage breaks FreeBSD
Date Tue, 08 Jul 2014 19:35:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055366#comment-14055366
] 

Chris Nauroth commented on HADOOP-10781:
----------------------------------------

Thanks, Colin.  I'd like to wait for [~kihwal] to chime in first to confirm before we proceed.
 I wouldn't want to put in an ifdef that wasn't really needed.

It looks like this was not merged down to branch-2.5, correct?  If so, can we please change
the target version and fix version, and also move attribution to the 2.6.0 section in CHANGES.txt?

> Unportable getgrouplist() usage breaks FreeBSD
> ----------------------------------------------
>
>                 Key: HADOOP-10781
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10781
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.4.1
>            Reporter: Dmitry Sivachenko
>            Assignee: Dmitry Sivachenko
>             Fix For: 2.5.0
>
>         Attachments: getgrouplist.patch
>
>
> getgrouplist() has different return values on Linux and FreeBSD:
> Linux: either the number of groups (positive) or -1 on error
> FreeBSD: 0 on success or -1 on error
> The return value of getgrouplist() is analyzed in Linux-specific way in 
> hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/hadoop_user_info.c,
in function hadoop_user_info_getgroups() which breaks FreeBSD.
> In this function you have 3 choices for the return value 
> ret = getgrouplist(uinfo->pwd.pw_name, uinfo->pwd.pw_gid,
>                          uinfo->gids, &ngroups);
> 1) ret > 0 : OK for Linux, it will be zero on FreeBSD.  I propose to change this to
ret >= 0
> 2) First condition is false and ret != -1:  impossible according to manpage
> 3) ret == 1 -- OK for both Linux and FreeBSD
> So I propose to change "ret > 0" to "ret >= 0" and (optionally) return 2nd case.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message