hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10733) Potential null dereference in CredentialShell#promptForCredential()
Date Fri, 18 Jul 2014 10:43:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066253#comment-14066253
] 

Hudson commented on HADOOP-10733:
---------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk #616 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/616/])
HADOOP-10733. Fix potential null dereference in CredShell. (Ted Yu via
omalley) (omalley: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1611419)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialShell.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/alias/TestCredShell.java


> Potential null dereference in CredentialShell#promptForCredential()
> -------------------------------------------------------------------
>
>                 Key: HADOOP-10733
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10733
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 3.0.0, 2.6.0
>
>         Attachments: hadoop-10733-v1.txt
>
>
> {code}
>       char[] newPassword1 = c.readPassword("Enter password: ");
>       char[] newPassword2 = c.readPassword("Enter password again: ");
>       noMatch = !Arrays.equals(newPassword1, newPassword2);
>       if (noMatch) {
>         Arrays.fill(newPassword1, ' ');
> {code}
> newPassword1 might be null, leading to NullPointerException in Arrays.fill() call.
> Similar issue for the following call on line 381:
> {code}
>       Arrays.fill(newPassword2, ' ');
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message