hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9603) Run "hdfs zkfc-formatZK" on a server in a non-namenode will cause a null pointer exception.
Date Mon, 21 Jul 2014 23:14:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069491#comment-14069491
] 

Hadoop QA commented on HADOOP-9603:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12642547/HADOOP-9603-0.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4334//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4334//console

This message is automatically generated.

> Run "hdfs zkfc-formatZK" on a server in a non-namenode  will cause a null pointer exception.
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9603
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9603
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: auto-failover, fs
>    Affects Versions: 2.0.4-alpha, 2.4.0
>            Reporter: WenJin Ma
>            Assignee: Masatake Iwasaki
>         Attachments: HADOOP-9603-0.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Run "hdfs zkfc-formatZK" on a server in a non-namenode  will cause a null pointer exception.
> {code}
> [hadoop@test bin]$ ./hdfs zkfc -formatZK
> Exception in thread "main" java.lang.NullPointerException
> at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187)
> at org.apache.hadoop.hdfs.tools.NNHAServiceTarget.<init>(NNHAServiceTarget.java:57)
> at org.apache.hadoop.hdfs.tools.DFSZKFailoverController.create(DFSZKFailoverController.java:128)
> at org.apache.hadoop.hdfs.tools.DFSZKFailoverController.main(DFSZKFailoverController.java:172)
> {code}
> I look at the code, found in the org.apache.hadoop.hdfs.DFSUtil.getSuffixIDs () method
does not make judgments on this issue.
> {code}
> static String[] getSuffixIDs(final Configuration conf, final String addressKey,
>       String knownNsId, String knownNNId,
>       final AddressMatcher matcher) {
>     String nameserviceId = null;
>     String namenodeId = null;
>     int found = 0;
>    //......do something
>    if (found > 1) { // Only one address must match the local address
>       String msg = "Configuration has multiple addresses that match "
>           + "local node's address. Please configure the system with "
>           + DFS_NAMESERVICE_ID + " and "
>           + DFS_HA_NAMENODE_ID_KEY;
>       throw new HadoopIllegalArgumentException(msg);
>     }
>     // If the IP is not a local address, found to be less than 1.
>     // There should be throw an exception with clear message rather than cause a null
pointer exception.       
>     return new String[] { nameserviceId, namenodeId };
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message