hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-4297) Enable Java assertions when running tests
Date Sat, 19 Jul 2014 07:40:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067429#comment-14067429
] 

Hadoop QA commented on HADOOP-4297:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12656708/c4297_20140719.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
                  org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
                  org.apache.hadoop.ipc.TestIPC

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4324//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4324//console

This message is automatically generated.

> Enable Java assertions when running tests
> -----------------------------------------
>
>                 Key: HADOOP-4297
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4297
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.19.0, 0.20.0
>            Reporter: Yoram Kulbak
>         Attachments: HADOOP-4297.patch, HADOOP-4297.patch, c4297_20140719.patch
>
>
> A suggestion to enable Java assertions in the project's build xml when running tests.
I think this would improve the build quality.
> To enable assertions add the following snippets to the JUnit tasks in build.xml:
> <assertions>
>      <enable />
> </assertions>
> --
> For example:
> <junit ... >
>      ...
>     <assertions>
>         <enable />
>     </assertions>
> </junit>
>  



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message