Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA4301118B for ; Tue, 17 Jun 2014 00:31:05 +0000 (UTC) Received: (qmail 66808 invoked by uid 500); 17 Jun 2014 00:31:04 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 66675 invoked by uid 500); 17 Jun 2014 00:31:04 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 66429 invoked by uid 99); 17 Jun 2014 00:31:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jun 2014 00:31:04 +0000 Date: Tue, 17 Jun 2014 00:31:04 +0000 (UTC) From: "Charles Lamb (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10696) Add optional tags to KeyProvider Options and Metadata MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033246#comment-14033246 ] Charles Lamb commented on HADOOP-10696: --------------------------------------- Hi Tucu, Just a few nits. As has been previously mentioned, there are whitespace issues. There are a bunch of places where there are trailing whitespace in the lines that should be removed. Is there any reason that KeyProvider.TAGS_FIELD can't be shared with KMSRESTConstants.TAGS_FIELD? TestKeyProvider.java: s/String[]{"a"/String[] {"a/ > Add optional tags to KeyProvider Options and Metadata > ----------------------------------------------------- > > Key: HADOOP-10696 > URL: https://issues.apache.org/jira/browse/HADOOP-10696 > Project: Hadoop Common > Issue Type: Improvement > Components: security > Affects Versions: 3.0.0 > Reporter: Alejandro Abdelnur > Assignee: Alejandro Abdelnur > Attachments: HADOOP-10696.patch, HADOOP-10696.patch, HADOOP-10696.patch > > > In addition to having an optional description, KeyProvider Options and Metadata should support optional tags to help categorize keys. > This would be useful for visualization purposes. -- This message was sent by Atlassian JIRA (v6.2#6252)