Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 13 Jun 2014 22:58:01 +0000 (UTC)
From: "Tsuyoshi OZAWA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12720158.1402336873561.130649.1402700281990@arcas>
In-Reply-To: <JIRA.12720158.1402336873561@arcas>
References: <JIRA.12720158.1402336873561@arcas>
Subject: [jira] [Commented] (HADOOP-10673) Update rpc metrics when the call
 throws an exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031302#comment-14031302 ] 

Tsuyoshi OZAWA commented on HADOOP-10673:
-----------------------------------------

[~mingma], thank you for the suggestion. I think this improvement is useful, too. One minor comment: both {{rpcMetrics}} and {{rpcDetailedMetrics}} are not final field, so how about adding null check before accessing them?

{code}
+         server.rpcMetrics.addRpcQueueTime(qTime);
+         server.rpcMetrics.addRpcProcessingTime(processingTime);
+         server.rpcDetailedMetrics.addProcessingTime(detailedMetricsName,
+             processingTime);
{code}

{code}
  protected RpcMetrics rpcMetrics;
  protected RpcDetailedMetrics rpcDetailedMetrics;
{code}

> Update rpc metrics when the call throws an exception
> ----------------------------------------------------
>
>                 Key: HADOOP-10673
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10673
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch, HADOOP-10673.patch
>
>
> Currently RPC metrics isn't updated when the call throws an exception. We can either update the existing metrics or have a new set of metrics in the case of exception.


--
This message was sent by Atlassian JIRA
(v6.2#6252)