Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7905811D3A for ; Mon, 9 Jun 2014 16:55:03 +0000 (UTC) Received: (qmail 31350 invoked by uid 500); 9 Jun 2014 16:55:02 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 31261 invoked by uid 500); 9 Jun 2014 16:55:02 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 31178 invoked by uid 99); 9 Jun 2014 16:55:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jun 2014 16:55:02 +0000 Date: Mon, 9 Jun 2014 16:55:02 +0000 (UTC) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025350#comment-14025350 ] Hadoop QA commented on HADOOP-10660: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649393/HADOOP-10660-v3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:red}-1 javac{color:red}. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4031//console This message is automatically generated. > GraphiteSink should implement Closeable > --------------------------------------- > > Key: HADOOP-10660 > URL: https://issues.apache.org/jira/browse/HADOOP-10660 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ted Yu > Assignee: Chen He > Attachments: HADOOP-10660-v2.patch, HADOOP-10660-v3.patch, HADOOP-10660.patch > > > GraphiteSink wraps OutputStreamWriter around socket's output stream. > Currently the socket is never closed. > GraphiteSink should implement Closeable such that MetricsSystem can close the socket when it is stopped. -- This message was sent by Atlassian JIRA (v6.2#6252)