Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 6 Jun 2014 15:46:04 +0000 (UTC)
From: "Ravi Prakash (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12718268.1401836002325.82145.1402069564089@arcas>
In-Reply-To: <JIRA.12718268.1401836002325@arcas>
References: <JIRA.12718268.1401836002325@arcas>
Subject: [jira] [Commented] (HADOOP-10660) GraphiteSink should implement
 Closeable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019951#comment-14019951 ] 

Ravi Prakash commented on HADOOP-10660:
---------------------------------------

Ted: I'm afraid I don't see where close() is being called either. AbstractGangliaSink->GangliaSink30->GangliaSink31 don't implement it either. I don't see a problem if it were added so if you can please point out where its being used, I have no objection. If its an external project, should we consider making MetricsSink implement Closeable (in a separate JIRA ofcourse)?

Chen: Thanks for the patch. However if we were to close the writer, I would expect to check during a putMetrics whether it was null, and perhaps log a message? Also a log message at close could be helpful in later debugging issues.

> GraphiteSink should implement Closeable
> ---------------------------------------
>
>                 Key: HADOOP-10660
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10660
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chen He
>         Attachments: HADOOP-10660.patch
>
>
> GraphiteSink wraps OutputStreamWriter around socket's output stream.
> Currently the socket is never closed.
> GraphiteSink should implement Closeable such that MetricsSystem can close the socket when it is stopped.


--
This message was sent by Atlassian JIRA
(v6.2#6252)