Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 3 Jun 2014 21:40:02 +0000 (UTC)
From: "Benoy Antony (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12718244.1401826447794.67875.1401831602634@arcas>
In-Reply-To: <JIRA.12718244.1401826447794@arcas>
References: <JIRA.12718244.1401826447794@arcas>
Subject: [jira] [Commented] (HADOOP-10659) Refactor AccessControlList to
 reuse utility functions and to improve performance
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017185#comment-14017185 ] 

Benoy Antony commented on HADOOP-10659:
---------------------------------------

The test failures are not related. These tests pass on my machine with the patch

> Refactor AccessControlList to reuse utility functions and to improve performance
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-10659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10659
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Minor
>         Attachments: HADOOP-10659.patch
>
>
> Minor improvements can be done on _AccessControlList_.
> Code Reusability:
> _AccessControlList_ sanitizes the input list to remove duplicate entries, trim entries. _StringUtils.getTrimmedStringCollection_ can be used in this case.
> Performance:
> _AccessControlList_  uses TreeSet to maintain set of users and groups.
> HashSet improves the performance slightly.


--
This message was sent by Atlassian JIRA
(v6.2#6252)