Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A94DD11575 for ; Mon, 9 Jun 2014 20:03:03 +0000 (UTC) Received: (qmail 18705 invoked by uid 500); 9 Jun 2014 20:03:03 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 18664 invoked by uid 500); 9 Jun 2014 20:03:03 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 18652 invoked by uid 99); 9 Jun 2014 20:03:03 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jun 2014 20:03:03 +0000 Date: Mon, 9 Jun 2014 20:03:03 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10571) Use Log.*(Object, Throwable) overload to log exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025664#comment-14025664 ] Arpit Agarwal commented on HADOOP-10571: ---------------------------------------- Hi [~sureshms] / [~stevel@apache.org], if you don't object could you please +1 the change? Steve, I'll volunteer to move this module to SLF4J separately. > Use Log.*(Object, Throwable) overload to log exceptions > ------------------------------------------------------- > > Key: HADOOP-10571 > URL: https://issues.apache.org/jira/browse/HADOOP-10571 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.4.0 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Attachments: HADOOP-10571.01.patch > > > When logging an exception, we often convert the exception to string or call {{.getMessage}}. Instead we can use the log method overloads which take {{Throwable}} as a parameter. -- This message was sent by Atlassian JIRA (v6.2#6252)