Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B6F8E111BE for ; Tue, 3 Jun 2014 02:59:02 +0000 (UTC) Received: (qmail 84207 invoked by uid 500); 3 Jun 2014 02:59:02 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 84161 invoked by uid 500); 3 Jun 2014 02:59:02 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 84150 invoked by uid 99); 3 Jun 2014 02:59:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2014 02:59:02 +0000 Date: Tue, 3 Jun 2014 02:59:02 +0000 (UTC) From: "Yi Liu (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-10561) Copy command with preserve option should handle Xattrs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10561?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-10561: ---------------------------- Attachment: HADOOP-10561.1.patch HADOOP-10561.1.patch Thanks @Charles Lamb for your comments. The new patch includes update for y= our comments. {quote} The usage message is a little bit confusing. At first it was unclear to me = that -ptopx was really -p with options for t, o, p, and x. I would if we co= uld make this a little clearer by saying something like this instead? public static final String USAGE =3D "\[-f\] \[-p | -p\[t|o|p|x\]\] .= .. "; or maybe public static final String USAGE =3D "\[-f\] \[-p | -p\[topx\]\] ... = "; {quote} OK, let's use the {{\[-f\] \[-p | -p\[topx\]\] ... }}. For the d= etail, user can get from {{hadoop fs -usage cp}} {quote} + "must be a directory. Passing -p preserves status\n" + + "(\[topx\]) (timestamps, ownership, permission, XATTR). \n" + + "If -p is specified with no , then preserves " + + "timestamps, ownership, permission. Passing -f\n" + Also, s/XATTR/XAttr/. {quote} Right, I change {{XATTR}} to {{xattr}}. > Copy command with preserve option should handle Xattrs > ------------------------------------------------------ > > Key: HADOOP-10561 > URL: https://issues.apache.org/jira/browse/HADOOP-10561 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 3.0.0 > Reporter: Uma Maheswara Rao G > Assignee: Yi Liu > Attachments: HADOOP-10561.1.patch, HADOOP-10561.1.patch, HADOOP-1= 0561.patch > > > The design docs for Xattrs stated that we handle preserve options with co= py commands > From doc: > Preserve option of commands like =E2=80=9Ccp -p=E2=80=9D shell command an= d =E2=80=9Cdistcp -p=E2=80=9D should work on XAttrs.=20 > In the case of source fs supports XAttrs but target fs does not support, = XAttrs will be ignored=20 > with warning message -- This message was sent by Atlassian JIRA (v6.2#6252)