Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B45E211524 for ; Wed, 18 Jun 2014 05:53:14 +0000 (UTC) Received: (qmail 63795 invoked by uid 500); 18 Jun 2014 05:53:14 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 63746 invoked by uid 500); 18 Jun 2014 05:53:14 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 63733 invoked by uid 99); 18 Jun 2014 05:53:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2014 05:53:14 +0000 Date: Wed, 18 Jun 2014 05:53:14 +0000 (UTC) From: "Steve Loughran (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-9361) Strictly define the expected behavior of filesystem APIs and write tests to verify compliance MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-9361: ----------------------------------- Attachment: HADOOP-9361-016.patch add code changes recommended by andrew # flag is rejects-seek-past-eof, negated and defaults to true # tests renamed to {{Test${FS}Contract{$Operation}}}, e.g {{TestHDFSContractAppend}}. # also: tagged openstack swift as returning false on missing source file on a rename(), as it catches the FNFE and downgrades it for consistency with HDFS. > Strictly define the expected behavior of filesystem APIs and write tests to verify compliance > --------------------------------------------------------------------------------------------- > > Key: HADOOP-9361 > URL: https://issues.apache.org/jira/browse/HADOOP-9361 > Project: Hadoop Common > Issue Type: Improvement > Components: fs, test > Affects Versions: 3.0.0, 2.4.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Attachments: HADOOP-9361-001.patch, HADOOP-9361-002.patch, HADOOP-9361-003.patch, HADOOP-9361-004.patch, HADOOP-9361-005.patch, HADOOP-9361-006.patch, HADOOP-9361-007.patch, HADOOP-9361-008.patch, HADOOP-9361-009.patch, HADOOP-9361-011.patch, HADOOP-9361-012.patch, HADOOP-9361-013.patch, HADOOP-9361-014.patch, HADOOP-9361-015.patch, HADOOP-9361-016.patch, HADOOP-9361.awang-addendum.patch > > > {{FileSystem}} and {{FileContract}} aren't tested rigorously enough -while HDFS gets tested downstream, other filesystems, such as blobstore bindings, don't. > The only tests that are common are those of {{FileSystemContractTestBase}}, which HADOOP-9258 shows is incomplete. > I propose > # writing more tests which clarify expected behavior > # testing operations in the interface being in their own JUnit4 test classes, instead of one big test suite. > # Having each FS declare via a properties file what behaviors they offer, such as atomic-rename, atomic-delete, umask, immediate-consistency -test methods can downgrade to skipped test cases if a feature is missing. -- This message was sent by Atlassian JIRA (v6.2#6252)