Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97E3B11E9D for ; Tue, 10 Jun 2014 00:41:03 +0000 (UTC) Received: (qmail 24635 invoked by uid 500); 10 Jun 2014 00:41:03 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 24575 invoked by uid 500); 10 Jun 2014 00:41:02 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 24564 invoked by uid 99); 10 Jun 2014 00:41:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jun 2014 00:41:02 +0000 Date: Tue, 10 Jun 2014 00:41:02 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-6350) Documenting Hadoop metrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025978#comment-14025978 ] Arpit Agarwal commented on HADOOP-6350: --------------------------------------- I reviewed the HDFS/common portions. A few comments below. Nothing worth blocking the checkin as this is a huge improvement over no documentation. # I am not sure what this means - _Each metrics record contains tags such as ProcessName, SessionId, and Hostname as additional information along with metrics._. How are these tags accessed, I don't see them in jconsole? Perhaps I am missing some basic knowledge, let me know if so. # Namenode - snapshot metrics are missing. # DataNode - DataNodeInfo metrics are missing. # DataNode - FsDatasetState metrics are missing. # Nitpick: we should use title case consistently for sub-headings e.g. rpcdetail --> RpcDetailed As a separate discussion I think long term maintenance of this documentation will be challenging. Does Java support declarative definition of metrics which can be used to auto-generate this documentation? Thanks for taking up this work! > Documenting Hadoop metrics > -------------------------- > > Key: HADOOP-6350 > URL: https://issues.apache.org/jira/browse/HADOOP-6350 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation, metrics > Affects Versions: 3.0.0, 2.1.0-beta > Reporter: Hong Tang > Assignee: Akira AJISAKA > Labels: metrics > Attachments: HADOOP-6350-sample-1.patch, HADOOP-6350-sample-2.patch, HADOOP-6350-sample-3.patch, HADOOP-6350.4.patch, HADOOP-6350.5.patch, HADOOP-6350.6.patch, HADOOP-6350.7.patch, sample1.png > > > Metrics should be part of public API, and should be clearly documented similar to HADOOP-5073, so that we can reliably build tools on top of them. -- This message was sent by Atlassian JIRA (v6.2#6252)