hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10710) hadoop.auth cookie is not properly constructed according to RFC2109
Date Mon, 30 Jun 2014 18:09:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047923#comment-14047923
] 

Hadoop QA commented on HADOOP-10710:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12653187/HADOOP-10710.007.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-auth
hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4191//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4191//console

This message is automatically generated.

> hadoop.auth cookie is not properly constructed according to RFC2109
> -------------------------------------------------------------------
>
>                 Key: HADOOP-10710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10710
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.4.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Juan Yu
>         Attachments: HADOOP-10710.001.patch, HADOOP-10710.002.patch, HADOOP-10710.003.patch,
HADOOP-10710.004.patch, HADOOP-10710.005.patch, HADOOP-10710.006.patch, HADOOP-10710.007.patch
>
>
> It seems that HADOOP-10379 introduced a bug on how hadoop.auth cookies are being constructed.
> Before HADOOP-10379, cookies were constructed using Servlet's {{Cookie}} class and corresponding
{{HttpServletResponse}} methods. This was taking care of setting attributes like 'Version=1'
and double-quoting the cookie value if necessary.
> HADOOP-10379 changed the Cookie creation to use a {{StringBuillder}} and setting values
and attributes by hand. This is not taking care of setting required attributes like Version
and escaping the cookie value.
> While this is not breaking HadoopAuth {{AuthenticatedURL}} access, it is breaking access
done using {{HtttpClient}}. I.e. Solr uses HttpClient and its access is broken since this
change.
> It seems that HADOOP-10379 main objective was to set the 'secure' attribute. Note this
can be done using the {{Cookie}} API.
> We should revert the cookie creation logic to use the {{Cookie}} API and take care of
the security flag via {{setSecure(boolean)}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message