hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10661) Ineffective user/passsword check in FTPFileSystem#initialize()
Date Wed, 04 Jun 2014 21:09:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018188#comment-14018188
] 

Ted Yu commented on HADOOP-10661:
---------------------------------

Null username with non-null password shouldn't be allowed, right ?

> Ineffective user/passsword check in FTPFileSystem#initialize()
> --------------------------------------------------------------
>
>                 Key: HADOOP-10661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10661
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>         Attachments: HADOOP-10661.patch
>
>
> Here is related code:
> {code}
>       userAndPassword = (conf.get("fs.ftp.user." + host, null) + ":" + conf
>           .get("fs.ftp.password." + host, null));
>       if (userAndPassword == null) {
>         throw new IOException("Invalid user/passsword specified");
>       }
> {code}
> The intention seems to be checking that username / password should not be null.
> But due to the presence of colon, the above check is not effective.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message