hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable
Date Mon, 09 Jun 2014 17:51:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025440#comment-14025440

Ravi Prakash commented on HADOOP-10660:

Thanks Ted! That makes sense. Perhaps we should do the same from GangliaSink (in another JIRA)

In the latest patch, we are still not assigning writer = null after close()

bq. Should socket become a member of GraphiteSink and be closed in close() ?
{noformat}Closing the returned OutputStream will close the associated socket.{noformat}
So closing the socket is unnecessary and should be removed from the patch.

> GraphiteSink should implement Closeable
> ---------------------------------------
>                 Key: HADOOP-10660
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10660
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chen He
>         Attachments: HADOOP-10660-v2.patch, HADOOP-10660-v3.patch, HADOOP-10660.patch
> GraphiteSink wraps OutputStreamWriter around socket's output stream.
> Currently the socket is never closed.
> GraphiteSink should implement Closeable such that MetricsSystem can close the socket
when it is stopped.

This message was sent by Atlassian JIRA

View raw message