hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable
Date Fri, 06 Jun 2014 15:46:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019951#comment-14019951
] 

Ravi Prakash commented on HADOOP-10660:
---------------------------------------

Ted: I'm afraid I don't see where close() is being called either. AbstractGangliaSink->GangliaSink30->GangliaSink31
don't implement it either. I don't see a problem if it were added so if you can please point
out where its being used, I have no objection. If its an external project, should we consider
making MetricsSink implement Closeable (in a separate JIRA ofcourse)?

Chen: Thanks for the patch. However if we were to close the writer, I would expect to check
during a putMetrics whether it was null, and perhaps log a message? Also a log message at
close could be helpful in later debugging issues.

> GraphiteSink should implement Closeable
> ---------------------------------------
>
>                 Key: HADOOP-10660
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10660
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chen He
>         Attachments: HADOOP-10660.patch
>
>
> GraphiteSink wraps OutputStreamWriter around socket's output stream.
> Currently the socket is never closed.
> GraphiteSink should implement Closeable such that MetricsSystem can close the socket
when it is stopped.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message