hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10656) The password keystore file is not picked by LDAP group mapping
Date Tue, 10 Jun 2014 22:57:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027175#comment-14027175
] 

Chris Nauroth commented on HADOOP-10656:
----------------------------------------

Hi, [~brandonli].  Nice catch, and thank you for fixing it.

This is not directly related to your patch, but I noticed that the {{LdapGroupsMapping#extractPassword}}
method is susceptible to a file descriptor leak.  If one of the {{Reader#read}} calls throws
an {{IOException}}, then we won't close the {{Reader}}.  Do you think we could fix this while
we're in this class?  I think we'd just need to move the {{Reader#close}} call into a finally
block.

> The password keystore file is not picked by LDAP group mapping
> --------------------------------------------------------------
>
>                 Key: HADOOP-10656
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10656
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.2.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HADOOP-10656.patch
>
>
> The user configured password file(LDAP_KEYSTORE_PASSWORD_FILE_KEY) will not be picked
by LdapGroupsMapping:
> In setConf():
> {noformat}
>     keystorePass =
>         conf.get(LDAP_KEYSTORE_PASSWORD_KEY, LDAP_KEYSTORE_PASSWORD_DEFAULT);
>     if (keystorePass.isEmpty()) {
>       keystorePass = extractPassword(
>         conf.get(LDAP_KEYSTORE_PASSWORD_KEY, LDAP_KEYSTORE_PASSWORD_DEFAULT)); 
>     }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message