hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10657) Have RetryInvocationHandler log failover attempt at INFO level
Date Fri, 06 Jun 2014 22:04:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020438#comment-14020438
] 

Jing Zhao commented on HADOOP-10657:
------------------------------------

For LOG.info seems like we usually do not need to call "isInfoEnabled". Other than that +1.


> Have RetryInvocationHandler log failover attempt at INFO level
> --------------------------------------------------------------
>
>                 Key: HADOOP-10657
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10657
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HADOOP-10657.patch
>
>
> RetryInovcationHandler uses worthLogging flag to decide if it will do logging. worthLogging
will be false for first fails over given invocationFailoverCount is zero. That addresses the
log noise where the second-listed NN is active.
> For other failover scenarios, it will be useful to log the error message at info level
for analysis purpose.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message