hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10652) Refactor Proxyusers to use AccessControlList
Date Fri, 20 Jun 2014 21:42:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039407#comment-14039407

Daryn Sharp commented on HADOOP-10652:

# {{AccessControlList}} is internally using the default conf for the group mapping, not the
conf provided to {{DefaultImpersonationProvider}} which could be incompatible
# In {{buildAcl}}, there are now two adjacent/nested ifs at the same indentation level.
# {{getAclKey}} has an uncuddled else and stray whitespace.  I'd recommend using {{lastIndexOf(".")}}
to cleanly strip off the suffix and entirely avoid the if/else
# I'd suggest using {{Pattern.quote}} for the literal parts of the regexs instead of trying
to backslash.
# Minor improvement in {{authorize}} is assign superUser then check for null.  Calling {{ugi#getRealUser}}
twice involves a lot work than you might think...

> Refactor Proxyusers to use AccessControlList  
> ----------------------------------------------
>                 Key: HADOOP-10652
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10652
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: HADOOP-10652.patch, HADOOP-10652.patch
> Currently Proxyuser specification  accepts a list of users and groups including wildcard
values. Same functionality is already encapsulated in _AccessControlList_ . It will be better
to refactor _ProxyUsers_ to use _AccessControlList_ instead of maintaining separate logic.

This message was sent by Atlassian JIRA

View raw message